Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): 🔊 add logging configuration for PyTorch Lightning and Transformers #128

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

onuralpszr
Copy link
Collaborator

@onuralpszr onuralpszr commented Feb 4, 2025

Description

This pull request introduces logging configurations for PyTorch Lightning and Transformers in the maestro/trainer module. The main changes involve adding a new logging configuration setup and ensuring that default logging settings are applied upon import.

Logging configuration setup:

  • maestro/trainer/__init__.py: Added imports for logging configuration functions and configured default logging settings on import. The __all__ list is updated to include set_lightning_logging and set_transformers_progress.

  • maestro/trainer/logger.py: Introduced functions configure_logging, set_lightning_logging, and set_transformers_progress to manage logging levels and progress bar settings for PyTorch Lightning and Transformers.

@onuralpszr onuralpszr self-assigned this Feb 4, 2025
@onuralpszr onuralpszr force-pushed the log/maestro branch 4 times, most recently from 99c3d2c to 6660853 Compare February 4, 2025 19:02
@onuralpszr onuralpszr requested a review from SkalskiP February 5, 2025 06:49
@onuralpszr onuralpszr added the enhancement New feature or request label Feb 5, 2025
@onuralpszr onuralpszr merged commit 7ae2b98 into develop Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant